Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow update-metadata breaks when a GitHub Repository doesn't exists #27

Closed
Rabenherz112 opened this issue Jun 10, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working, or incorrect

Comments

@Rabenherz112
Copy link
Collaborator

The workflow update-metadata encounters an issue when a GitHub repository does not exist. This problem results in the job being halted and further checks not being performed.

Expected output:
https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/5205347247/jobs/9390696384

Actual output:
https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/5216295216/jobs/9414872295

@nodiscc nodiscc added the bug Something isn't working, or incorrect label Jun 10, 2023
@nodiscc nodiscc self-assigned this Jun 10, 2023
nodiscc added a commit that referenced this issue Jun 15, 2023
@nodiscc
Copy link
Member

nodiscc commented Jun 16, 2023

Thanks for taking the time to report this.

Fixed in ce136cf, metadata updates and URL checks now run independently, in parallel https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/5284187401.

@nodiscc nodiscc closed this as completed Jun 16, 2023
@Rabenherz112
Copy link
Collaborator Author

Sorry to annoy you again, but are you sure that the action works now (for me, it looks like it now broke completely)
https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/5284187401/jobs/9561352646#step:2:8

@nodiscc nodiscc reopened this Jun 16, 2023
@nodiscc
Copy link
Member

nodiscc commented Jun 16, 2023

Not annoying at all, thank you for the report.

are you sure that the action works now

It didn't, I had only checked that jobs were being run in parallel - but the url_check job was missing a checkout step - added in c7e09df -> problem fixed https://github.com/awesome-selfhosted/awesome-selfhosted-data/actions/runs/5289713083

Also made it possible to trigger the workflow manually at any time, without waiting for the time set in the cron expression (9345d7c).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, or incorrect
Development

No branches or pull requests

2 participants