Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
shape: Use an explicit move_to to set rounded_rect position
All other shape did it. While it usually have no side effects, as seen in #920 screenshot from @actionless, there is instances where this produce a invalid rectangle.
- Loading branch information
441587a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! now it's fine
i am wondering, could we move some smart_wibox's logic to wibox?
currently i have overridden
naughty
like that:master...actionless:rounded-naughty
i am wondering how easy it could be to bring such shaping behaviour to upstream (of course it will be better to use
beautiful
instead of the hardcoded shape)441587a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, but really, really, this is enough for 3.6. I just want my tooltip PR merged (btw, can you comment on the issue regarding xresource, thanks) then that's it. I will be against merging any new code other than bug fixes. There is 1700 commits and 4 years since the last release... Plus there is tons of mature new features the 3.5/stable users miss for no good reasons.
And me and @mindeunix also have notification shapes using dirty hacks. I planned to do it, it was geometry_overhaul part 3.05 (3.04 was for awful.menu), but that PR pull some other code from the dynamic layout code (it places wiboxes using wibox.layout and the placement API) and I wont merge this for 3.6. Same goes for the gears.pattern/gears.pixmap PR and the big "merge my widgets" PR. Those are on ice.
441587a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please give a link to that issue?
UPD: hopefully i've found (and fixed) it
btw, could you check those two, #772 and #877