-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
menubar error in awesome 4.0 #1348
Comments
Somewhere there is a nother bug report about menubar initialisation, but I cannot find it right now. diff --git a/lib/menubar/init.lua b/lib/menubar/init.lua
index 10ad65c2d..46a9675d9 100644
--- a/lib/menubar/init.lua
+++ b/lib/menubar/init.lua
@@ -196,6 +196,8 @@ end
-- @return table List of items for current page.
local function get_current_page(all_items, query, scr)
scr = get_screen(scr)
+ print("get_current_page called for", scr)
+ print(debug.traceback())
if not instance.prompt.width then
instance.prompt.width = compute_text_width(instance.prompt.prompt, scr)
end
@@ -350,6 +352,7 @@ end
--- Create the menubar wibox and widgets.
-- @tparam[opt] screen scr Screen.
local function initialize(scr)
+ print("initialize called for", scr)
instance.wibox = wibox({})
instance.widget = menubar.get(scr)
instance.wibox.ontop = true |
I experience the same issue. On the first invocation of
All subsequent invocations yield
I'll try applying the patch now. |
@rasendubi What's you LGI version? |
NixOS has an ancient version of LGI: https://github.com/NixOS/nixpkgs/blob/98a9d815e05dd56aba0f9040d96092335cd90444/pkgs/top-level/lua-packages.nix#L385 (It's 0.7.2 and it is from 2013) Turns out that menubar needs at least version 0.8.0 (from 2014, so also quite old) since commit 4eb8085. Edit: I propose "fixing" this by increasing our minimum lgi version from 0.7.1 to 0.8.0 and to make menubar's initialisation more robust. |
I'll update LGI now and report back. |
Updated LGI to 0.9.1 and I don't see an error now. |
Opened: NixOS/nixpkgs#21580 |
Works for me too :) |
We still have to do something on our side for this, like bumping the code that checks for too-old-lgi. :-) |
Turns out that menubar already uses features that were only added in that version. Fixes: awesomeWM#1348 Signed-off-by: Uli Schlachter <psychon@znc.in>
Turns out that menubar already uses features that were only added in that version. Fixes: #1348 Signed-off-by: Uli Schlachter <psychon@znc.in>
Output of
awesome --version
:How to reproduce the issue:
Start awesome and press
super
+p
Actual result:
share/awesome/lib/menubar/init.lua:199: attempt to index field 'prompt' (a nil value)
Expected result:
I'd like to see the menu ;-)
I'm running NixOS and this problem occoured with an update from v3.5 to v4.0.
The text was updated successfully, but these errors were encountered: