Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client key bindings for some windows don't work #699

Closed
psychon opened this issue Feb 15, 2016 · 0 comments
Closed

Client key bindings for some windows don't work #699

psychon opened this issue Feb 15, 2016 · 0 comments

Comments

@psychon
Copy link
Member

psychon commented Feb 15, 2016

I just understood one more part of #670: Key bindings for clients with "accepts input: false" in their WM_HINTS do not work. Since the window doesn't actually get the input focus, input events for our key bindings don't work either. An example for such a window is xeyes.

Working around that might be tough....

This was introduced with 2f78ec5 (and the equivalent commit that is part of awesome 3.5.7). Before this, we had "whatever contains the mouse pointer gets key events" (which isn't really a nice thing, but at least key bindings worked this way). However, technically this was already broken before.

psychon added a commit to psychon/awesome that referenced this issue Feb 28, 2016
Instead of focusing the root window, we now create a "focus window" inside of
our frame window. This window is placed so that it is not visible, but we can
grab key bindings on it to simulate the window having the input focus.

Fixes: awesomeWM#699
Signed-off-by: Uli Schlachter <psychon@znc.in>
psychon added a commit that referenced this issue Feb 29, 2016
Instead of focusing the root window, we now create a "focus window" inside of
our frame window. This window is placed so that it is not visible, but we can
grab key bindings on it to simulate the window having the input focus.

Fixes: #699
Signed-off-by: Uli Schlachter <psychon@znc.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant