Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected selected check in awful.tag.set_screen() #1600

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

Drauthius
Copy link
Contributor

Previously it would check if the awful.tag.selected function existed,
and not whether the tag was actually selected.

Previously it would check if the awful.tag.selected function existed,
and not whether the tag was actually selected.
@codecov
Copy link

codecov bot commented Feb 25, 2017

Codecov Report

Merging #1600 into master will decrease coverage by -0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   80.69%   80.66%   -0.04%     
==========================================
  Files         278      278              
  Lines       17348    17344       -4     
==========================================
- Hits        13999    13990       -9     
- Misses       3349     3354       +5
Flag Coverage Δ
#functionaltests 64.3% <100%> (-0.05%)
#samples 63.12% <100%> (ø)
#unittests 73.79% <100%> (ø)
Impacted Files Coverage Δ
lib/awful/tag.lua 71.85% <100%> (-0.2%)
lib/awful/layout/suit/magnifier.lua 63.29% <ø> (-5.39%)
lib/awful/tooltip.lua 85.59% <ø> (-0.43%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052cda9...28709c2. Read the comment docs.

@blueyed
Copy link
Member

blueyed commented Feb 25, 2017

Thanks for this fix!

We should add a regression test for this. /cc @Elv13

@Elv13 Elv13 merged commit 3b0269d into awesomeWM:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants