Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss the notification without triggering default action on right-click #3906

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danimateo
Copy link

This is an improvement to the problem presented by @BarbUk 's comment here: #3863 (comment)

On right click, the notification dismisses without triggering the default action. On left click, behavior is the same as until now.

Copy link
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.27%. Comparing base (8b1f895) to head (01b0652).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3906   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         935      935           
  Lines       60129    60130    +1     
=======================================
+ Hits        54880    54883    +3     
+ Misses       5249     5247    -2     
Flag Coverage Δ
gcov 91.27% <50.00%> (+<0.01%) ⬆️
luacov 93.90% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/naughty/layout/box.lua 94.19% <50.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants