Fix #599 (issue with focus on multiple instances) #607
Conversation
|
The second commit looks fine to me (glad to hear that my idea works). The first one makes travis fail to build this, because neither lua 5.1, lua 5.2 nor luajit work anymore while they did before. :-) I consider the problem with multiple installed lua versions to be a bug in CMake / FindLua and I don't know what to do about it. See #361 and https://cmake.org/Bug/view.php?id=15756. I think we can just cherry-pick the second commit and be done with this PR (if @blueyed agrees)? |
|
@ kdt3rd : against which version of awesome was this patch created? It's not awesome-3.5.6 ... |
|
@Manfred-Knick @kdt3rd |
|
Confirmation: |
When there are multiple X11 screens (i.e. :0.0 and :0.1) for zaphod mode style X setups, this triggers a refresh of focus when the instance running on a particular root receives the mouse
|
I don't seem to easily be able to remove the initial patch against awesomeConfig.cmake - I wanted to remove it earlier, but realized I'd already pushed it to my remote. I guess either make the patch elsewise and reject this pull request, or if you want, I'll clean up my fork and re-submit. thanks |
Yes, you should be able to use |
|
(Force push: I guess that this would be |
kdt3rd
force-pushed
the
multi_instance
branch
from
814ee78
to
6016353
Compare
|
OK, thanks, I've patched up that branch, and Travis seems happy now. thanks for the patience |
|
Could you please port/apply fc8c91c to the 3.5 branch as well? |
|
Cherry-picked into 3.5. |
This fixes #599 as far as I'm concerned - meaning it changes behavior to fix the issues I was seeing with running multiple instances of awesome on separate screens.
The awesomeConfig.cmake I accidentally checked in prior to this branch, and now github wants it unconditionally, and I can't seem to deselect it. However, if you do require lua v5.3, it does fix an issue with FindLua when there are multiple versions of lua installed on the system (since lua doesn't really do pkg config very well)