Skip to content

Commit

Permalink
Improve accessibility of tooltip help (#2856)
Browse files Browse the repository at this point in the history
* #2524 Add tabindex to help icons for accessibility

* #2524 Add option name to help text for accessibility

* #2524 Remove colon from end of labels

* #2524 Remove colon from end of labels

* #2524 Remove colon from end of labels

* Improve appearance of tooltip for regular users #2524
  • Loading branch information
wpsmort authored and michaeltorbert committed Sep 4, 2019
1 parent e6d9beb commit 851e11a
Show file tree
Hide file tree
Showing 4 changed files with 78 additions and 78 deletions.
2 changes: 1 addition & 1 deletion admin/aioseop_module_class.php
Expand Up @@ -2788,7 +2788,7 @@ function get_option_row( $name, $opts, $args ) {
if ( 'none' != $opts['label'] ) {
$tmp_help_text = $info->get_help_text( $name );
if ( isset( $tmp_help_text ) && ! empty( $tmp_help_text ) ) {
$display_help = '<a class="aioseop_help_text_link" style="cursor: help;" title="%s"></a><label class="aioseop_label textinput">%s</label>';
$display_help = '<a tabindex="0" class="aioseop_help_text_link" style="cursor: help;" title="<h4 aria-hidden>%2$s:</h4> %1$s"></a><label class="aioseop_label textinput">%2$s</label>';
$help_text = sprintf( $display_help, $info->get_help_text( $name ), $opts['name'] );
} else {
$help_text = $opts['name'];
Expand Down

0 comments on commit 851e11a

Please sign in to comment.