Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% sign in title breaks Preview Snippet #2526

Closed
wpsmort opened this issue May 29, 2019 · 2 comments
Closed

% sign in title breaks Preview Snippet #2526

wpsmort opened this issue May 29, 2019 · 2 comments
Assignees
Milestone

Comments

@wpsmort
Copy link

wpsmort commented May 29, 2019

Describe the bug
Placing multiple % signs in the title of a post or page breaks the Preview Snippet.

NOTE: It does not break the placeholder text in the Title field or the doc title tag in the source code.

To Reproduce
In order to reproduce this issue, follow these steps:

  1. Install All in One SEO Pack on a new test site
  2. Create a new Post and set a title without a %. You'll see that the Preview Snippet is fine
  3. Now add two % signs to the title with some text in between each % sign, for example:

Testing 100% and another 100%

You'll see the Preview Snippet doesn't show any of the text between the two % signs. See the screenshot below.

Expected behavior
Text between percent signs should be displayed correctly in the Preview Snippet.

Screenshots
Screen Shot 2019-05-29 at 12 31 27 PM

Version Info:

  • WordPress version: 5.2.1
  • All in One SEO Pack version: 2.12.1
  • PHP version: 7.2.0

Arnaud believes that this is related to #1408.

@wpsmort
Copy link
Author

wpsmort commented May 29, 2019

@arnaudbroes Please test back to see what version this bug first occurred in.

@arnaudbroes
Copy link
Contributor

I believe this is related to #1408.

@michaeltorbert michaeltorbert modified the milestones: 3.1, 3.2 Jun 10, 2019
michaeltorbert pushed a commit that referenced this issue Jul 13, 2019
* Fix preview snippet bugs #1408 #2526

* Change @SInCE changelog. #1408 #2526

* Add phpDoc #1408 #2526

* Add static preview snippet title part(s) back #1408 #2526

* Update phpDoc

* Fix Scrutinzer issues #1408 #2526

* Fix variable naming

* Dev-Fix WPCS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants