Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1$ to %1$s #1674

Merged
merged 2 commits into from Sep 20, 2018
Merged

Fix 1$ to %1$s #1674

merged 2 commits into from Sep 20, 2018

Conversation

shoheitanaka
Copy link
Contributor

Fix 1$ to %1$s and 2$ to %2$s

@shoheitanaka
Fix 1$ to %1$s
4cb6691 
Fix  1$ to %1$s and  2$ to %2$s
@michaeltorbert michaeltorbert added this to the 2.9 milestone Sep 7, 2018
@michaeltorbert
Copy link
Contributor

michaeltorbert commented Sep 7, 2018 •
edited

This needs an issue created.

@contactashish13
Copy link
Contributor

ref #1888

@michaeltorbert michaeltorbert modified the milestones: 2.9, 2.8 Sep 9, 2018
@wpsmort
Copy link

wpsmort commented Sep 10, 2018 •
edited

@shoheitanaka I tested this PR and it does not fix the problem. Here is what is output by this PR:

screen shot 2018-09-10 at 9 30 21 am

@wpsmort wpsmort assigned contactashish13 and unassigned wpsmort Sep 10, 2018
@wpsmort wpsmort modified the milestones: 2.8, 2.9 Sep 10, 2018
@contactashish13 contactashish13 mentioned this pull request Sep 11, 2018
Closed
@michaeltorbert michaeltorbert changed the base branch from master to 2.9 September 18, 2018 16:38
@michaeltorbert michaeltorbert merged commit 28ae0d3 into awesomemotive:2.9 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shoheitanaka @michaeltorbert @contactashish13 @wpsmort