Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict WC notice to our own screens #2590

Merged
merged 1 commit into from
Jun 6, 2019
Merged

restrict WC notice to our own screens #2590

merged 1 commit into from
Jun 6, 2019

Conversation

michaeltorbert
Copy link
Contributor

@michaeltorbert michaeltorbert commented Jun 6, 2019

Issue #2583

Proposed changes

Because a handful of users are experiencing problems with getting a dismissed notice to stay dismissed, we should at least restrict it to our own screens, which is the more considerate option anyway, and probably what we should have done from the start.

Types of changes

What types of changes does your code introduce?

  • Improves existing functionality

Checklist

  • I've selected the appropriate branch (ie x.y rather than master).
  • I've created an appropriate title, descriptive of what the PR does.
  • Travis-ci runs with no errors.
  • I have added tests that prove my fix is effective/my feature works or have created an issue for it (if appropriate).
  • I have added necessary documentation, or have created an issue for docs (if appropriate).

Testing instructions

  • Install both AIOSEOP and WooCommerce to trigger the notice.
  • Bonus: test on a site having the persistence problems.

@michaeltorbert michaeltorbert changed the base branch from master to 3.0.3 June 6, 2019 14:00
@michaeltorbert michaeltorbert added this to the 3.0.3 milestone Jun 6, 2019
@wpsmort
Copy link

wpsmort commented Jun 6, 2019

This is tested and is good.

@arnaudbroes
Copy link
Contributor

This is approved.

@michaeltorbert michaeltorbert removed their assignment Jun 6, 2019
@michaeltorbert michaeltorbert merged commit 570749e into 3.0.3 Jun 6, 2019
@arnaudbroes arnaudbroes deleted the issue-2583 branch August 27, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants