Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter hook to disable schema.org markup #2915

Merged
merged 4 commits into from
Sep 20, 2019
Merged

Add filter hook to disable schema.org markup #2915

merged 4 commits into from
Sep 20, 2019

Conversation

michaeltorbert
Copy link
Contributor

@michaeltorbert michaeltorbert commented Sep 17, 2019 •
edited by arnaudbroes

Issue #2913

Proposed changes

Adds an API filter hook to programmatically disable our schema.org markup.

Types of changes

What types of changes does your code introduce?

  • Adds new API hooks

Checklist

  • I've selected the appropriate branch (ie x.y rather than master).
  • I've created an appropriate title, descriptive of what the PR does.
  • Travis-ci runs with no errors.

Testing instructions

  • By default this conditional is true. If you do nothing, our schema markup should be outputted as normal.
  • Returning false should cause schema to not load. (You can either make a callback function or just use __return_false.)
  • Feel free to get fancy with it, and only add the filter for certain post types, a certain post, etc.
  • Our schema output should still load anywhere else on the site, not specified in the above step.

@michaeltorbert michaeltorbert added this to the 3.2.8 milestone Sep 17, 2019
@arnaudbroes

This comment has been minimized.

Sign in to view
@arnaudbroes arnaudbroes assigned EkoJR and unassigned arnaudbroes Sep 18, 2019
@arnaudbroes
Copy link
Contributor

arnaudbroes commented Sep 18, 2019 •
edited

FYI, the remaining two Grunt issues can be ignored and are addressed in #2921.

EkoJR
EkoJR suggested changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@EkoJR EkoJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 line that has a couple issues.

aioseop_class.php Outdated Show resolved Hide resolved
@EkoJR EkoJR assigned michaeltorbert and unassigned EkoJR Sep 19, 2019
@michaeltorbert
Copy link
Contributor Author

@arnaudbroes @EkoJR Can you both test and code review again?

EkoJR
EkoJR approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@EkoJR EkoJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this, works as intended, and looks good. Approved.

@EkoJR
Copy link
Contributor

EkoJR commented Sep 19, 2019

Grunt was also clean.

@arnaudbroes
Copy link
Contributor

I've tested this and code looks good too.

@michaeltorbert michaeltorbert merged commit c610d78 into 3.2.8 Sep 20, 2019
@michaeltorbert michaeltorbert deleted the issue-2913 branch September 20, 2019 12:26
michaeltorbert added a commit that referenced this pull request Sep 23, 2019
@michaeltorbert
Add filter hook to disable schema.org markup (#2915)
9fead51 
* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string
michaeltorbert pushed a commit that referenced this pull request Oct 16, 2019
@arnaudbroes @michaeltorbert
Update help text for Sitemap Indexes setting (#2961)
da3ef28 
* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Update help text for Sitemap Indexes setting #2954
michaeltorbert pushed a commit that referenced this pull request Oct 16, 2019
@arnaudbroes @michaeltorbert
Remove version check for Gutenberg/Chrome compatibility fix and check…
8931d73 
… if user agent is set (#2928)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Remove WP v5.3 version check and move function out of action hook #2914

* Invert version_compare and prefix functions #2914

* Fix phpDocs #2914

* Rename compat-gutenberg.php to gutenberg-chrome.php #2914

* Fix undefined index HTTP_USER_AGENT #2952
arnaudbroes added a commit that referenced this pull request Oct 28, 2019
@arnaudbroes
3.2.10 to 3.3 (#2986)
8b8b50c 
* Update help text for Sitemap Indexes setting (#2961)

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Update help text for Sitemap Indexes setting #2954

* Remove version check for Gutenberg/Chrome compatibility fix and check if user agent is set (#2928)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Remove WP v5.3 version check and move function out of action hook #2914

* Invert version_compare and prefix functions #2914

* Fix phpDocs #2914

* Rename compat-gutenberg.php to gutenberg-chrome.php #2914

* Fix undefined index HTTP_USER_AGENT #2952

* version bump to 3.2.10

* Update readme.txt

* Delete duplicate file

* Fix file paths
michaeltorbert pushed a commit that referenced this pull request Oct 29, 2019
@arnaudbroes @michaeltorbert
Add support for Google Tag Manager (#2985)
f870d31 
* Add support for Google Tag Manager #2983

* 3.3 (#17)

* Add PHPCompatibility sniffs to PHPCS & fix issues (#2907)

* Add PHPCompatibility sniffs to PHPCS #2851

* Ignore Composer & VScode for Git #2851

* Fix PHP compatibility issues (1) #2851

* Don't check PHP compatibility of unit tests #2851

* Fix PHP compatibility issues (2) #2851

* Move parse_ini_string() to compatibility/php-functions.php #2851

* Fix typo #2851

* Fix typo (2) #2851

* Add Grunt task set for Travis CI builds #2851

* Add Travis CI support for PHPCompatibility #2851

* Print installed sniffs after "composer install" in Travis CI #2851

* Delete composer.lock #2851

* Move parse_ini_string() from aioseop_functions.php to compatibility/php-functions.php #2851

* Remove compat-gutenberg.php

* Readd compat-gutenberg.php

* Fix Grunt #2851

* Fix path to compat files #2851

* Add package-lock.json to .gitignore #2851

* Add composer.lock to .gitignore #2851

* Fix phpDoc in compatibility/php-funcitons.php #2851

* Change schema person's name & logo to add the option of manually ente… (#2920)

* Change schema person's name & logo to add the option of manually entered name & image

* Grunt

* Add Schema to AMP plugin (#2879)

* Fix loose comparator in AMP Head causing a return with empty description

* Move AMP hooks to separate function for AMP hooks

* Add remove hook for AMP Schema

* Add AIOSEOP's Schema to AMP

* Dev-change aioseop_amp_description filter to only affect meta descriptions

* Add filter aioseop_amp_schema to enable/disable schema on AMP posts

* Dev-Fix disable schema filter and no meta desc.

* Invert if statement and add third decimal to phpDoc since tags #506

* Add third decimal to phpDoc since tag (2) #506

* Fix Grunt issue

* Fix Grunt issue (2)

* Change bin path for phpcs (#2966)

* Change bin path for phpcs #2965

* Delete phpcs and phpcompatibility script entries #2965

* Add new line to init-grunt.sh #2965

* Refactor operations in All_in_One_SEO_Pack_Opengraph::add_meta() (#2941)

* Change variable variables to direct variables

* Change early initialize thumbnail variable to use image variable

* Change operations from call filter to call method

* Add filter documentation

* Change to group operations together

* Add dev notes

* Grunt

* Dev-Fix filter params

* Dev-Add dev note

* Dev-Fix error on SSL enabled site

* Dev-Change duplicate code to function

* Only output meta descriptions if autogenerate descriptions is enabled (#2947)

* Fix issue 2439

* Dev-Change to strict comparator

* Dev-Fix empty value check

* Dev-Change applied changes

The excerpt was being added elsewhere as a final fallback

* Revert previous changes #2439

* Refactor code #2439

* Remove unneeded check #2439

* Fix Grunt issue

* Fix SEO for search results page (#2964)

* Added/updated help text for new Schema fields (#2959)

* #2958 Added/updated help text for new Schema fields

* Add missing i18n domains #2958

* Resolves #2411 (#2955)

* 3.2.10 to 3.3 (#2986)

* Update help text for Sitemap Indexes setting (#2961)

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Update help text for Sitemap Indexes setting #2954

* Remove version check for Gutenberg/Chrome compatibility fix and check if user agent is set (#2928)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Remove WP v5.3 version check and move function out of action hook #2914

* Invert version_compare and prefix functions #2914

* Fix phpDocs #2914

* Rename compat-gutenberg.php to gutenberg-chrome.php #2914

* Fix undefined index HTTP_USER_AGENT #2952

* version bump to 3.2.10

* Update readme.txt

* Delete duplicate file

* Fix file paths

* Fix Grunt issues #2990

* Fix Grunt issues #2983

* Fix undefined class error #2983
michaeltorbert pushed a commit that referenced this pull request Oct 30, 2019
@arnaudbroes @michaeltorbert
Refactor & move get_robots_meta() (#2910)
2e2b2eb 
* Refactor & move get_robots_meta() #2684

* Grunt fixes #2684

* PHPCS fixes #2684

* Fix minor bugs #2684

* tmp

* Remove tmp unit tests #2684

* Fix Grunt issues #2684

* Fix Scrutinizer issues #2684

* Fix phpDoc

* Add remote XDebug listener script for VScode #2684

* Skip test_title_format_macros #2684

* Fix fatal error and Grunt #2684

* Remove check for AIOSEOP Pro #2684

* PR comments #2684

* 3.3 (#17)

* Add PHPCompatibility sniffs to PHPCS & fix issues (#2907)

* Add PHPCompatibility sniffs to PHPCS #2851

* Ignore Composer & VScode for Git #2851

* Fix PHP compatibility issues (1) #2851

* Don't check PHP compatibility of unit tests #2851

* Fix PHP compatibility issues (2) #2851

* Move parse_ini_string() to compatibility/php-functions.php #2851

* Fix typo #2851

* Fix typo (2) #2851

* Add Grunt task set for Travis CI builds #2851

* Add Travis CI support for PHPCompatibility #2851

* Print installed sniffs after "composer install" in Travis CI #2851

* Delete composer.lock #2851

* Move parse_ini_string() from aioseop_functions.php to compatibility/php-functions.php #2851

* Remove compat-gutenberg.php

* Readd compat-gutenberg.php

* Fix Grunt #2851

* Fix path to compat files #2851

* Add package-lock.json to .gitignore #2851

* Add composer.lock to .gitignore #2851

* Fix phpDoc in compatibility/php-funcitons.php #2851

* Change schema person's name & logo to add the option of manually ente… (#2920)

* Change schema person's name & logo to add the option of manually entered name & image

* Grunt

* Add Schema to AMP plugin (#2879)

* Fix loose comparator in AMP Head causing a return with empty description

* Move AMP hooks to separate function for AMP hooks

* Add remove hook for AMP Schema

* Add AIOSEOP's Schema to AMP

* Dev-change aioseop_amp_description filter to only affect meta descriptions

* Add filter aioseop_amp_schema to enable/disable schema on AMP posts

* Dev-Fix disable schema filter and no meta desc.

* Invert if statement and add third decimal to phpDoc since tags #506

* Add third decimal to phpDoc since tag (2) #506

* Fix Grunt issue

* Fix Grunt issue (2)

* Change bin path for phpcs (#2966)

* Change bin path for phpcs #2965

* Delete phpcs and phpcompatibility script entries #2965

* Add new line to init-grunt.sh #2965

* Refactor operations in All_in_One_SEO_Pack_Opengraph::add_meta() (#2941)

* Change variable variables to direct variables

* Change early initialize thumbnail variable to use image variable

* Change operations from call filter to call method

* Add filter documentation

* Change to group operations together

* Add dev notes

* Grunt

* Dev-Fix filter params

* Dev-Add dev note

* Dev-Fix error on SSL enabled site

* Dev-Change duplicate code to function

* Only output meta descriptions if autogenerate descriptions is enabled (#2947)

* Fix issue 2439

* Dev-Change to strict comparator

* Dev-Fix empty value check

* Dev-Change applied changes

The excerpt was being added elsewhere as a final fallback

* Revert previous changes #2439

* Refactor code #2439

* Remove unneeded check #2439

* Fix Grunt issue

* Fix SEO for search results page (#2964)

* Added/updated help text for new Schema fields (#2959)

* #2958 Added/updated help text for new Schema fields

* Add missing i18n domains #2958

* Resolves #2411 (#2955)

* 3.2.10 to 3.3 (#2986)

* Update help text for Sitemap Indexes setting (#2961)

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Update help text for Sitemap Indexes setting #2954

* Remove version check for Gutenberg/Chrome compatibility fix and check if user agent is set (#2928)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Remove WP v5.3 version check and move function out of action hook #2914

* Invert version_compare and prefix functions #2914

* Fix phpDocs #2914

* Rename compat-gutenberg.php to gutenberg-chrome.php #2914

* Fix undefined index HTTP_USER_AGENT #2952

* version bump to 3.2.10

* Update readme.txt

* Delete duplicate file

* Fix file paths

* Fix Grunt issues #2990

* Skip failing unit test #2684

* Remove launch.json

* PR comments #2684

* Change identation

* Grunt fixes
arnaudbroes added a commit that referenced this pull request Nov 4, 2019
@arnaudbroes
Refactor aioseop-count-chars.js (#2976)
f3f25ca 
* Refactor aioseop-count-chars.js #2755

* Clear preview snippet description when "Autogenerated Descriptions" is disabled #2975

* Fix #2927, #2747, #2337

* Set character treshold to 55 for OG:title and OG:description #2413

* Change let to var + minify

* Use minified JavaScript files instead

* Fix variable naming

* Fix Grunt issues

* Revert minified js

* 3.3 (#17)

* Add PHPCompatibility sniffs to PHPCS & fix issues (#2907)

* Add PHPCompatibility sniffs to PHPCS #2851

* Ignore Composer & VScode for Git #2851

* Fix PHP compatibility issues (1) #2851

* Don't check PHP compatibility of unit tests #2851

* Fix PHP compatibility issues (2) #2851

* Move parse_ini_string() to compatibility/php-functions.php #2851

* Fix typo #2851

* Fix typo (2) #2851

* Add Grunt task set for Travis CI builds #2851

* Add Travis CI support for PHPCompatibility #2851

* Print installed sniffs after "composer install" in Travis CI #2851

* Delete composer.lock #2851

* Move parse_ini_string() from aioseop_functions.php to compatibility/php-functions.php #2851

* Remove compat-gutenberg.php

* Readd compat-gutenberg.php

* Fix Grunt #2851

* Fix path to compat files #2851

* Add package-lock.json to .gitignore #2851

* Add composer.lock to .gitignore #2851

* Fix phpDoc in compatibility/php-funcitons.php #2851

* Change schema person's name & logo to add the option of manually ente… (#2920)

* Change schema person's name & logo to add the option of manually entered name & image

* Grunt

* Add Schema to AMP plugin (#2879)

* Fix loose comparator in AMP Head causing a return with empty description

* Move AMP hooks to separate function for AMP hooks

* Add remove hook for AMP Schema

* Add AIOSEOP's Schema to AMP

* Dev-change aioseop_amp_description filter to only affect meta descriptions

* Add filter aioseop_amp_schema to enable/disable schema on AMP posts

* Dev-Fix disable schema filter and no meta desc.

* Invert if statement and add third decimal to phpDoc since tags #506

* Add third decimal to phpDoc since tag (2) #506

* Fix Grunt issue

* Fix Grunt issue (2)

* Change bin path for phpcs (#2966)

* Change bin path for phpcs #2965

* Delete phpcs and phpcompatibility script entries #2965

* Add new line to init-grunt.sh #2965

* Refactor operations in All_in_One_SEO_Pack_Opengraph::add_meta() (#2941)

* Change variable variables to direct variables

* Change early initialize thumbnail variable to use image variable

* Change operations from call filter to call method

* Add filter documentation

* Change to group operations together

* Add dev notes

* Grunt

* Dev-Fix filter params

* Dev-Add dev note

* Dev-Fix error on SSL enabled site

* Dev-Change duplicate code to function

* Only output meta descriptions if autogenerate descriptions is enabled (#2947)

* Fix issue 2439

* Dev-Change to strict comparator

* Dev-Fix empty value check

* Dev-Change applied changes

The excerpt was being added elsewhere as a final fallback

* Revert previous changes #2439

* Refactor code #2439

* Remove unneeded check #2439

* Fix Grunt issue

* Fix SEO for search results page (#2964)

* Added/updated help text for new Schema fields (#2959)

* #2958 Added/updated help text for new Schema fields

* Add missing i18n domains #2958

* Resolves #2411 (#2955)

* 3.2.10 to 3.3 (#2986)

* Update help text for Sitemap Indexes setting (#2961)

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Update help text for Sitemap Indexes setting #2954

* Remove version check for Gutenberg/Chrome compatibility fix and check if user agent is set (#2928)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Remove WP v5.3 version check and move function out of action hook #2914

* Invert version_compare and prefix functions #2914

* Fix phpDocs #2914

* Rename compat-gutenberg.php to gutenberg-chrome.php #2914

* Fix undefined index HTTP_USER_AGENT #2952

* version bump to 3.2.10

* Update readme.txt

* Delete duplicate file

* Fix file paths

* Fix Grunt issues #2990

* Add characterCounter to ignored JS variables

* Fix bugs

* Update character counter when editor changes #2977

* Fix bug where counter background colour doesn't change

* PR comments

* Support non-default plugin path

* Remove unused code

* Remove unneeded variable declaration

* Include post-new.php as edit page

* Use legacy code for taxonomies

* Fix Grunt issues

* Revert minified scripts

* Variable alignment

* Use let (ES6) and align variables
arnaudbroes added a commit that referenced this pull request Nov 11, 2019
@arnaudbroes
Merge master into 3.3 (#3012)
86bc9f1 
* Update help text for Sitemap Indexes setting (#2961)

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Update help text for Sitemap Indexes setting #2954

* Remove version check for Gutenberg/Chrome compatibility fix and check if user agent is set (#2928)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Only show Welcome Screen on major version updates (#2922)

* add get_major_version function #2662

* only show welcome screen on major version updates #2662

* remove function

* move function to aioseop_functions.php

* Remove class keywords #2662

* Grunt & WPCS

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg (#2921)

* Fix conflict between Chromium v77.0.3865.75 and Gutenberg #2914

* Grunt fixes #2914

* Revert removed package tag #2914

* Target WP 5.0 <= X < 5.3 #2914

* Move echo statement inside version check #2914

* Do proper version checks #2914

* Fix phpDoc #2914

* Add filter hook to disable schema.org markup (#2915)

* Add filter hook to disable schema.org markup

* fix return value for schema filter

* Grunt fix #2913

* reversing schema filter logic and using a boolean instead of string

* Remove WP v5.3 version check and move function out of action hook #2914

* Invert version_compare and prefix functions #2914

* Fix phpDocs #2914

* Rename compat-gutenberg.php to gutenberg-chrome.php #2914

* Fix undefined index HTTP_USER_AGENT #2952

* version bump to 3.2.10

* Update readme.txt

* Update .gitattributes

* Update .gitattributes

* Update .gitattributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EkoJR EkoJR EkoJR approved these changes

@arnaudbroes arnaudbroes Awaiting requested review from arnaudbroes

Assignees

@michaeltorbert michaeltorbert

Labels
None yet
Projects
None yet
Milestone
3.2.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaeltorbert @arnaudbroes @EkoJR