Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed login reset password link should not always go to the checkout page #8100

Closed
robincornett opened this issue Sep 2, 2020 · 1 comment · Fixed by #8117
Closed

Failed login reset password link should not always go to the checkout page #8100

robincornett opened this issue Sep 2, 2020 · 1 comment · Fixed by #8117
Labels
Milestone

Comments

@robincornett
Copy link
Contributor

Bug Report

Expected behavior

When I click a password reset link and request a password reset, I expect the final redirect to take me back to where I was, or the front page of the site if that is not possible.

Actual behavior

Since changes in 2.9.24, using an EDD login form and failing to log in (due to an incorrect username or password), the password reset link includes a redirect to the EDD checkout screen. This is the case even if the login shortcode is on the profile page, or the purchase history page.

Steps to reproduce the behavior

  1. Create a page with the EDD login shortcode.
  2. Log in from that page with an invalid username or password.
  3. Fill out the form. You are redirected to the checkout screen.

Information (if a specific version is affected):

PHP Version: 7.4.1
EDD Version (or branch): master, 2.9.24
WordPress Version: 5.5.1

Any other relevant information:
Introduced in PR #8085.

@robincornett robincornett added this to the 2.10 milestone Sep 2, 2020
@goldkast
Copy link

I have same problem!!!

@robincornett robincornett linked a pull request Sep 21, 2020 that will close this issue
robincornett added a commit that referenced this issue Sep 22, 2020
robincornett added a commit that referenced this issue Sep 22, 2020
robincornett added a commit that referenced this issue Oct 30, 2020
robincornett added a commit that referenced this issue Nov 20, 2020
@ashleyfae ashleyfae mentioned this issue Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants