Volume discount addons applies addon twice

[TheCrowned]

Bug Report

Expected behavior

When 3 products are at checkout, a volume discount should be applied. The same final price should be carried over to PayPal for payment.

Actual behavior

The volume discount is correctly shown in the checkout page, but when going to PayPal, the amount is incorrect. The amount shown to pay is original - 2*volume discount. The user pays and the EDD transaction then fails due to PayPal IPN reporting an incorrect amount.

Steps to reproduce the behavior

Go to https://postpaycounter.com/addons, add 5 products to cart (had to bump it up so customers are not affected) and proceed to checkout. Take care at the total amount displayed at checkout and the one you are shown to be paid in paypal.

Information (if a specific version is affected):

PHP Version: 7.3.21

EDD Version (or branch): 2.9.26

Volume discount: 1.2.5

WordPress Version: 4.9.6

Any other relevant information:
This did not happen before I updated EDD. I hadn't done so for months, so was quite behind.
Volume discounts is not up to date because my license expired, but used to work absolutely fine!

[robincornett]

This has been reported/resolved in #6837, I think--do you have a staging/test site where you can try the release/2.10 branch, which is currently in active development, to confirm that it fixes the issue for you?

[TheCrowned]

Will I be able to revert to 2.9 after using 2.10, or does it change the database in some way?

[ashleyfae]

Will I be able to revert to 2.9 after using 2.10, or does it change the database in some way?

There are no database changes so you can revert to 2.10. However, we still recommend testing this on a staging site -- not your live one.

[arraypress]

This extension was deprecated I believe due to this issue (but don't quote me on this). It was recommended to use Discounts Pro instead.

[TheCrowned]

This extension was deprecated I believe due to this issue (but don't quote me on this). It was recommended to use Discounts Pro instead.

Well, if EDD is willing to convert my license then I will gladly move :) Not willing to pay again though.

[pippinsplugins]

We can swap the license for you. Email support@easydigitaldownloads.com please.

…

On Mon, Feb 15, 2021 at 8:02 AM Stefano Ottolenghi ***@***.***> wrote: This extension was deprecated I believe due to this issue (but don't quote me on this). It was recommended to use Discounts Pro instead. Well, if EDD is willing to convert my license then I will gladly move :) Not willing to pay again though. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8382 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH4O7KEOVZYTHFMKZLMPULS7ESO5ANCNFSM4XNSE3EA> .