Attachment unit tests suddenly failing

[ashleyfae]

Bug Report

Some of our attachment-related unit tests are suddenly sporadically failing. For example: https://buildkite.com/sandhills-development-llc/easy-digital-downloads/builds/339#8a0a10a5-23b7-42cb-af04-c58af76dea20

There were 4 errors:

1) Tests_Query_Filters::test_edd_block_attachments_no_parent_bail

getimagesize(../assets/images/loading.gif): failed to open stream: No such file or directory

/tmp/wordpress/wp-includes/media.php:4985
/tmp/wordpress/wp-admin/includes/image.php:917
/tmp/wordpress/wp-admin/includes/image.php:482
/tmp/PvF7Jx5jvhhLuSD6If66N8W5EYihzFJq/tests/tests-query-filters.php:53


2) Tests_Query_Filters::test_edd_block_attachments_no_download_bail

getimagesize(../assets/images/loading.gif): failed to open stream: No such file or directory

/tmp/wordpress/wp-includes/media.php:4985
/tmp/wordpress/wp-admin/includes/image.php:917
/tmp/wordpress/wp-admin/includes/image.php:482
/tmp/PvF7Jx5jvhhLuSD6If66N8W5EYihzFJq/tests/tests-query-filters.php:95


3) Tests_Query_Filters::test_edd_block_attachments_not_restricted_bail

getimagesize(../assets/images/loading.gif): failed to open stream: No such file or directory

/tmp/wordpress/wp-includes/media.php:4985
/tmp/wordpress/wp-admin/includes/image.php:917
/tmp/wordpress/wp-admin/includes/image.php:482
/tmp/PvF7Jx5jvhhLuSD6If66N8W5EYihzFJq/tests/tests-query-filters.php:157


4) Tests_Query_Filters::test_edd_block_attachments_die

getimagesize(../assets/images/loading.gif): failed to open stream: No such file or directory

/tmp/wordpress/wp-includes/media.php:4985
/tmp/wordpress/wp-admin/includes/image.php:917
/tmp/wordpress/wp-admin/includes/image.php:482
/tmp/PvF7Jx5jvhhLuSD6If66N8W5EYihzFJq/tests/tests-query-filters.php:219

I'm not quite sure why because:

1. Those files do exist.
2. The unit tests will pass in some environments, but randomly(?) not a couple others. So it's not failing all the time.
3. That code hasn't changed.

I initially experimented with changing the file path from relative:

$filename 		= '../assets/images/loading.gif';

to absolute:

$filename 		= EDD_PLUGIN_DIR . '/assets/images/loading.gif';

and that appeared to fix the problem for me, but broke it for Robin.

Information (if a specific version is affected):

PHP Version:

EDD Version (or branch): Master could be affected, but it's hard to tell because there's more movement going in 3.0. Definitely seen the issues in the 3.0 branch though.

WordPress Version:

Any other relevant information:

[ashleyfae]

I think the unit tests fail with WordPress latest

Looks like 5.7 introduced wp_getimagesize(), wh ich is used in file_is_displayable_image(). wp_getimagesize() is running getimagesize(), which is failing.