Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/6286 – Table endpoint support #6339

Merged
merged 27 commits into from
Jan 30, 2018
Merged

Issue/6286 – Table endpoint support #6339

merged 27 commits into from
Jan 30, 2018

Commits on Jan 30, 2018

  1. Set up a report with a valid endpoint as a static fixture for tests-r… 

    …eport, adjust existing Report tests to use it.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    26f2b2e View commit details
    Browse the repository at this point in the history

  2. Improve styling of h3 tags inside the vertical tabs card wrapper.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    0646a49 View commit details
    Browse the repository at this point in the history

  3. Pass the current $report object to the legacy edd_reports_view|tab ho… 

    …oks.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    0124cef View commit details
    Browse the repository at this point in the history

  4. Introduce a Table_Endpoint handler for list tables.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    010c3be View commit details
    Browse the repository at this point in the history

  5. Make Endpoint::check_view() protected vs private so it's accessible i… 

    …n sub-classes.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    1d590af View commit details
    Browse the repository at this point in the history

  6. Introduce a Report::get_endpoint() method for retrieving a single end… 

    …point by ID and view group. Add 7 tests for it.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    1c5794e View commit details
    Browse the repository at this point in the history

  7. Flesh out the view defaults for table views.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7625809 View commit details
    Browse the repository at this point in the history

  8. Restore a get_endpoints() test.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    09860e1 View commit details
    Browse the repository at this point in the history

  9. Fortify the tests-report $report fixture with a valid display callback.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    92366be View commit details
    Browse the repository at this point in the history

  10. Remove the padding style from the item card.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    bb78868 View commit details
    Browse the repository at this point in the history

  11. Docs fix.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    7164cae View commit details
    Browse the repository at this point in the history

  12. Log exceptions when adding endpoints or reports via the namespaced wr… 

    …apper functions.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    952ed41 View commit details
    Browse the repository at this point in the history

  13. Introduce a display_endpoint_group() method to Report for displaying … 

    …all of a given endpoint group, such as tiles.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    008710d View commit details
    Browse the repository at this point in the history

  14. Introduce a new group_callback attribute to all whitelisted endpoint … 

    …views.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    bba25a2 View commit details
    Browse the repository at this point in the history

  15. Introduce a group display callback for tiles, default_display_tiles_g… 

    …roup() and implement it in the default report template.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    db24332 View commit details
    Browse the repository at this point in the history

  16. Add a helper to retrieve a view's group_callback value. Implement it … 

    …in Report::display_endpoint_group().
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    93f131d View commit details
    Browse the repository at this point in the history

  17. Add two tests for get_endpoint_group_callback().

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    369687e View commit details
    Browse the repository at this point in the history

  18. More logically reorder some functions in reports-functions.php.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    939babf View commit details
    Browse the repository at this point in the history

  19. Convert the Reports page header to an h1.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    88b54e2 View commit details
    Browse the repository at this point in the history

  20. Display the centered report label in the card wrapper via an h2.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4becaaf View commit details
    Browse the repository at this point in the history

  21. Introduce a group display callback for tables, including a test.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    87135cb View commit details
    Browse the repository at this point in the history

  22. Implement displaying the tables endpoint group in the default report … 

    …tab markup.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    74461e1 View commit details
    Browse the repository at this point in the history

  23. Check if the list table class exists before trying to require it and … 

    …instantiate the class in Table_Endpoint.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9808e58 View commit details
    Browse the repository at this point in the history

  24. Define coversDefaultClass for Tile_Endpoint tests.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    320a26b View commit details
    Browse the repository at this point in the history

  25. Add a test class for Table_Endpoint.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    c4a0101 View commit details
    Browse the repository at this point in the history

  26. Only setup the $errors prop in Base_Object if not already set.

    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    a979d84 View commit details
    Browse the repository at this point in the history

  27. Initialize $errors in Table_Endpoint manually as the parent construct… 

    …or (which initializes $errors) isn't called until much later in the loading order.
    @DrewAPicture
    DrewAPicture committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    da7d036 View commit details
    Browse the repository at this point in the history