Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wp_safe_redirect with EDD's login #8127

Merged
merged 7 commits into from
Nov 30, 2020
Merged

Use wp_safe_redirect with EDD's login #8127

merged 7 commits into from
Nov 30, 2020

Conversation

robincornett
Copy link
Contributor

Fixes #8087

@robincornett robincornett linked an issue Sep 28, 2020 that may be closed by this pull request
EDD Login process should use wp_safe_redirect #8087
Closed
ashleyfae
ashleyfae suggested changes Sep 29, 2020
View reviewed changes
includes/login-register.php Outdated Show resolved Hide resolved
@robincornett @ashleyfae
Escape redirect URL
581a27c 
Co-authored-by: Ashley Gibson <ashley@nosegraze.com>
ashleyfae
ashleyfae approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@ashleyfae ashleyfae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that:

  • Without a filter, wp_safe_redirect() is used.
  • With a filter, wp_redirect() is used and an "unsafe" redirect can be set.

spencerfinnell
spencerfinnell requested changes Nov 16, 2020
View reviewed changes
includes/login-register.php Outdated Show resolved Hide resolved
ashleyfae
ashleyfae suggested changes Nov 20, 2020
View reviewed changes
includes/login-register.php Outdated Show resolved Hide resolved
spencerfinnell
spencerfinnell requested changes Nov 20, 2020
View reviewed changes
includes/login-register.php Outdated Show resolved Hide resolved
@robincornett @spencerfinnell
Update edd_login_redirect doc block
38a75a9 
Co-authored-by: Spencer Finnell <spencerfinnell@gmail.com>
@ashleyfae ashleyfae merged commit 5719e29 into release/2.10 Nov 30, 2020
@ashleyfae ashleyfae deleted the issue/8087 branch November 30, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerfinnell spencerfinnell spencerfinnell approved these changes

@ashleyfae ashleyfae ashleyfae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EDD Login process should use wp_safe_redirect
3 participants
@robincornett @spencerfinnell @ashleyfae