Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete uploaded CSV file once import has completed #8233

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Conversation

robincornett
Copy link
Contributor

@robincornett robincornett commented Nov 30, 2020

Fixes #8162

Proposed Changes:

  1. When an import is marked done, delete the uploaded file.

@ashleyfae I have based this off of release/2.10 but did not milestone the issue so you can change if you want. I think there is an open PR about the payments importer for 3.0; this could be added to that or managed separately as you prefer.

To test: run an import for Payments or Downloads. The uploaded CSV file is not added to the media library, but navigate to your current month's upload directory and ensure that the file is removed once the import is done (if you check while the import is happening, it should be there).

@robincornett robincornett linked an issue Nov 30, 2020 that may be closed by this pull request
@ashleyfae ashleyfae self-requested a review January 20, 2021 11:04
@ashleyfae ashleyfae merged commit fc1e3eb into release/2.10 Jan 20, 2021
@ashleyfae ashleyfae deleted the issue/8162 branch January 20, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imported CSV Accessible in Uploads Directory
2 participants