Add Build Script to Include Required Stripe Dependencies #8429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes action that removes core bootstrap. Pretty fragile and should be done more directly.
|
The only issue I see with this is that we're not replacing the text domain of Going to see if I can get something into the bash script to do that. |
|
Nevermind, looks like our grunt task corrects these on the fly. Super! |
ashleyfae
approved these changes
Feb 24, 2021
robincornett
approved these changes
Feb 24, 2021
|
I appreciate you checking that @robincornett ! |
ashleyfae
reviewed
Feb 25, 2021
ashleyfae
approved these changes
Feb 25, 2021
cklosowski
approved these changes
Feb 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
npm run buildscript to generate a.zipthat includes Stripe gateway dependencies.