Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize code with best practice #11

Open
ihavecoke opened this issue May 3, 2016 · 1 comment
Open

optimize code with best practice #11

ihavecoke opened this issue May 3, 2016 · 1 comment
Assignees
@ihavecoke
Labels
enhancement in progress

Comments

@ihavecoke
Copy link
Contributor

ihavecoke commented May 3, 2016 •
edited
Loading

  1. before_filter -> before_action
  2. replace "" to ''
  3. some sql to active methods
  4. format code
@ihavecoke ihavecoke changed the title remove some old DEPRECATION methods optimize code with best practice May 3, 2016
@bimohxh
Copy link
Member

bimohxh commented May 3, 2016

Thinks! has merged

@ihavecoke ihavecoke self-assigned this May 7, 2016
@ihavecoke ihavecoke changed the title optimize code with best practice optimize code with best practice May 7, 2016
ihavecoke added a commit that referenced this issue May 8, 2016
@ihavecoke
#11 optimize refectory repos subjects and practices
2ea2b11
ihavecoke added a commit that referenced this issue May 8, 2016
@ihavecoke
#11 optimize add migrate captain repos migrate
53c1877
ihavecoke added a commit that referenced this issue May 8, 2016
@ihavecoke
#11 optimize add migrate repos to 4 table names : captain_repos, capt…
57155d5 
…ain_github_repos, captain_github_repo_docs, captain_github_repo_owners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihavecoke ihavecoke

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ihavecoke @bimohxh