Add data access, in memory and file #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput data, api access interface, base stock interactor that will be used by all use cases, GraphParser for future use cases and graph handling
…ta access interface to describe what that use case might need
rickygrosvenor-pramanick
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Is the DataAccessInterface supposed to be left empty? If not then write TODO within the body of the interface but otherwise I think everything seems fine. Again, I like that the method names are more detailed. I will approve for now but yeah just add TODO comments something is not supposed to be left empty.
|
I don't think they are necessary as they were superseded by the actual implementations in other folders. So, removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an account can be created or deleted using a username and password and saved to a CSV file in the root directory. additional methods like get, existsByName, save, save User, and the constructor have been added to allow for future signup and login use cases.
I will link the issue related to the history and portfolio not saving.