Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetNews table added #123

Merged
merged 5 commits into from Nov 27, 2023
Merged

GetNews table added #123

merged 5 commits into from Nov 27, 2023

Conversation

quiz3
Copy link
Collaborator

@quiz3 quiz3 commented Nov 26, 2023

I added a table to display the news retrieved by the GetNews use case.

Unfortunately, I discovered a bug in my use case. I believe the table stuff works but I haven't tested it properly since the GetNews use case it telling me that the ticker is not found or API did not respond every time I enter a valid ticker.

Pls help!

@quiz3
Copy link
Collaborator Author

quiz3 commented Nov 26, 2023

I added a table to display the news retrieved by the GetNews use case.

Unfortunately, I discovered a bug in my use case. I believe the table stuff works but I haven't tested it properly since the GetNews use case it telling me that the ticker is not found or API did not respond every time I enter a valid ticker.

Pls help!

Okay so I figured out the problem, which was actually in the GetNewsView. I have successfully created a table in the GetNewsView. It only shows one item of news, so the scroll feature will be added in the future.

@quiz3 quiz3 marked this pull request as ready for review November 27, 2023 00:44
Copy link
Collaborator

@gursi26 gursi26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass, review pass

@gursi26 gursi26 merged commit a1b75fa into main Nov 27, 2023
2 checks passed
@gursi26 gursi26 deleted the get-news-table branch November 27, 2023 00:48
@quiz3 quiz3 linked an issue Nov 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetNews output displayed
2 participants