Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sped up the back button by 2x by removing unnecessary API call #140

Merged
merged 1 commit into from Nov 27, 2023

Conversation

awesominat
Copy link
Owner

GetCompanyNews was only being called to get the FullName, but that is already in the transaction history.
essentially, in portfolio => in history, so we can grab the full name from the pre-queried transaction history.

Copy link
Collaborator

@gursi26 gursi26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple and clever pr. Good job.

@gursi26 gursi26 merged commit bc770ad into main Nov 27, 2023
2 checks passed
@gursi26 gursi26 deleted the speed-up-back-button branch November 29, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants