Made back instant #142
Merged
Made back instant #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed incorrect logic in transaction view interactor
…I call only happens upon refresh
gursi26
requested changes
Nov 27, 2023
| @@ -31,7 +31,7 @@ public void execute() { | |||
|
|
|||
| Transaction transaction = new TopupTransaction(curBalance + amountToAdd, new PricePoint(LocalDate.now(), curBalance)); | |||
|
|
|||
| super.addToHistory(userHistory, "Stonks App", user, curBalance + amountToAdd, curBalance, transaction); | |||
| super.addToHistory(userHistory, "Stonks App", curBalance, transaction); | |||
There was a problem hiding this comment.
why are we adding to history on reset? I was under the impression that a reset clears everything, including resetting current balance to 10000, removing all owned stocks and clearing history?
|
Also, could you resolve the merge conflicts? |
gursi26
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138
essentially, the price for every stock owned was fetched upon dashboard execution every time.
now, it will always use the last seen price of the stock and will only query to get the up-to-date prices when the refresh button is called