New Buy/Sell tests, Refactor Useless Files, Remove Useless Methods, 28% coverage (1/4) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… almost every scenario
awesominat
changed the title
quiz3
approved these changes
Dec 2, 2023
| @@ -51,10 +45,36 @@ | |||
| <version>2.10.1</version> | |||
| <scope>compile</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
This is great. This is what I wanted us to do earlier. JUnit5 on top!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #188
This pr:
a. buying stock and verifying stock was bought in the portfolio and history
b. getting balance for both buy and sell
c. selling stock and verifying change was reflected in portfolio and history
d. getting buy news
e. edge cases like negative numbers, tickers that dont exist, and buying/selling with not enough money/assets
f. getting buy news with invalid ticker
g. verifying all output datas of buy and sell are as expected after each action
also, we have now switched to JUnit 5 for its BeforeEach decorator.