Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Testing for GetTransactionHistory Interface Adapters #214

Merged
merged 2 commits into from Dec 3, 2023
Merged

Added Testing for GetTransactionHistory Interface Adapters #214

merged 2 commits into from Dec 3, 2023

Conversation

rickygrosvenor-pramanick
Copy link
Collaborator

Screenshot 2023-12-03 at 01 58 43 TLDR: 96% Line Coverage

awesominat
awesominat requested changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@awesominat awesominat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the folder name to interface_adapter and change the file name to be GetTransactionHistoryInterfaceAdapterTest as code coverage won't include your test unless it matches the main interface_adapter name (when running it separately)

@awesominat awesominat self-requested a review December 3, 2023 19:26
awesominat
awesominat approved these changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@awesominat awesominat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@awesominat awesominat merged commit 488b23b into main Dec 3, 2023
2 checks passed
@awesominat awesominat mentioned this pull request Dec 3, 2023
Closed
@gursi26 gursi26 deleted the getTransactionHistory-interface-adapters branch December 4, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awesominat awesominat awesominat approved these changes

@gursi26 gursi26 Awaiting requested review from gursi26

@quiz3 quiz3 Awaiting requested review from quiz3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rickygrosvenor-pramanick @awesominat