Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DashboardView implemented properly #78

Merged
merged 1 commit into from Nov 21, 2023
Merged

DashboardView implemented properly #78

merged 1 commit into from Nov 21, 2023

Conversation

quiz3
Copy link
Collaborator

@quiz3 quiz3 commented Nov 21, 2023

Since we fixed all the compile errors in main, I need to re-request the Dashboard View implementation that I made earlier (along with the changes to the interface adapter DashboardViewModel).

@quiz3 quiz3 linked an issue Nov 21, 2023 that may be closed by this pull request
Copy link
Collaborator

@gursi26 gursi26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, I think the next step is to work on #79

@gursi26 gursi26 merged commit 3cf1a91 into main Nov 21, 2023
1 check passed
@gursi26 gursi26 deleted the dashboard-view-v2 branch November 21, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard View
2 participants