Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed username mention in the project #91

Merged
merged 2 commits into from Nov 24, 2023
Merged

removed username mention in the project #91

merged 2 commits into from Nov 24, 2023

Conversation

awesominat
Copy link
Owner

@awesominat awesominat commented Nov 24, 2023 •
edited

we dont have usernames anymore, so a refactoring change is appropriate

@awesominat awesominat changed the title removed usernames in the buy interactor, input data, and controller removed username mention in the project Nov 24, 2023
@awesominat awesominat linked an issue Nov 24, 2023 that may be closed by this pull request
username removal from project #93
Closed
gursi26
gursi26 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@gursi26 gursi26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@gursi26 gursi26 merged commit e8b4726 into main Nov 24, 2023
1 check passed
@gursi26 gursi26 deleted the removed-username-in-buy branch November 24, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gursi26 gursi26 gursi26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

username removal from project
2 participants
@awesominat @gursi26