Transaction history Interactor and OutputData reimplemented. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiz3
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
This is good. These interface adapters will help you to implement the view.
Something to note: you noted in a comment that you should consult someone about the constructor for GetTransactionHistoryState, which is currently nonexistent. @gursi26 or @awesominat can likely help with clarifying the requirements around that. You are correct in that it is not currently required for our application to successfully compile.
rickygrosvenor-pramanick
added a commit
that referenced
this pull request
Nov 25, 2023
* Created GetTransactionHistory Interface Adapters - Need to be polished * Made Changes to the GetTransactionHistoryInteractor and OutputData
quiz3
added a commit
that referenced
this pull request
Nov 25, 2023
* Created GetTransactionHistory Interface Adapters - Need to be polished * Made Changes to the GetTransactionHistoryInteractor and OutputData * Implemented Interface Adapters for GetTransactionHistory UseCase * Fixed Dashboard buttons, removed QUIT, and tidied up the use case and view model. * removed usernames in the buy interactor, input data, and controller * removed other username references in all project files * Restructure sell buy viewmodels implement buy view (#92) * removed usernames in the buy interactor, input data, and controller * removed other username references in all project files * restructued buy and sell presents and views because the Presenters directly took in the View instead of the ViewModel, making it uncomfortable to instantiate use case. added Buy View buttons, connected them to controller, added input sanitization * Transaction history Interactor and OutputData reimplemented. (#99) * Created GetTransactionHistory Interface Adapters - Need to be polished * Made Changes to the GetTransactionHistoryInteractor and OutputData * DashboardView refresh button implemented (#97) --------- Co-authored-by: quiz3 <113859565+quiz3@users.noreply.github.com> Co-authored-by: Zain <zainhmoustafa@gmail.com> Co-authored-by: awesominat <110934811+awesominat@users.noreply.github.com> Co-authored-by: Stephen S <sjs.scott@mail.utoronto.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented the Interactor and OutputData so that we don't have awkward nesting of a List<List<List>>.