Changed ini_set('xdebug.overload_var_dump', 0)

to ini_set('xdebug.overload_var_dump', '0')
awesomite · Oct 1, 2018 · 6e52303 · 6e52303
1 parent 1305542
commit 6e52303
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## [1.2.1] - 2018-10-01
+
+Function [`ini_set`](http://php.net/manual/en/function.ini-set.php) expects second argument as string,
+changed `ini_set('xdebug.overload_var_dump', 0)` to `ini_set('xdebug.overload_var_dump', '0')`.
+
 ## [1.2.0] - 2018-09-29
 
 Added support for `use` keyword in anonymous functions, e.g.:
@@ -76,6 +81,7 @@ $reflectionProp->getValue($obj);
 
 This version contains the same source code as [0.12.0].
 
+[1.2.1]: https://github.com/awesomite/var-dumper/compare/v1.2.0...v1.2.1
 [1.2.0]: https://github.com/awesomite/var-dumper/compare/v1.1.0...v1.2.0
 [1.1.0]: https://github.com/awesomite/var-dumper/compare/v1.0.3...v1.1.0
 [1.0.3]: https://github.com/awesomite/var-dumper/compare/v1.0.2...v1.0.3

diff --git a/src/InternalVarDumper.php b/src/InternalVarDumper.php
@@ -31,14 +31,16 @@ public function dump($var)
     {
         $iniKey = 'xdebug.overload_var_dump';
         $previousVal = \ini_get($iniKey);
-        \ini_set($iniKey, 0);
+        \ini_set($iniKey, '0');
 
         if ($this->displayPlaceInCode) {
             $this->dumpPlaceInCode(0);
         }
         \var_dump($var);
 
-        \ini_set($iniKey, $previousVal);
+        if (false !== $previousVal) {
+            \ini_set($iniKey, $previousVal);
+        }
     }
 
     public function dumpAsString($var)