Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a flat layout for the tilt engine config #247

Closed
mojavelinux opened this issue Mar 11, 2013 · 5 comments
Closed

Use a flat layout for the tilt engine config #247

mojavelinux opened this issue Mar 11, 2013 · 5 comments

Comments

@mojavelinux
Copy link
Member

A recent commit added support for configuring tilt engines by the output extension. However, the change required introducing an additional level of nesting in the site configuration.

I'd like to propose an alternative flat layout that will be simpler and less error prone:

slim:
  :format: :html5
slim|xml:
  :format: :xhtml

The value after the pipe (|) is an explicit output extension to customize the options for a specific output format (in this case XML).

@mojavelinux
Copy link
Member Author

See issue #240 for the discussion leading up to this issue.

@ghost ghost assigned mojavelinux Mar 11, 2013
@LightGuard
Copy link
Member

Not that we'll be doing it all over the place, but this would introduce extra parsing after we've already done json parsing, correct?

@mojavelinux
Copy link
Member Author

No, this is standard stuff. It's all in the key we attempt to retrieve in the base tilt handler.

@LightGuard
Copy link
Member

Okay, if we're not doing any extra parsing for this, I'm fine.

On Mon, Mar 11, 2013 at 3:13 PM, Dan Allen notifications@github.com wrote:

No, this is standard stuff. It's all in the key we attempt to retrieve in
the base tilt handler.


Reply to this email directly or view it on GitHubhttps://github.com//issues/247#issuecomment-14743092
.

Jason Porter
http://en.gravatar.com/lightguardjp

@mojavelinux
Copy link
Member Author

Resolved by f76fd64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants