Fix deprecated messages from rspec mock and any_number_of_time. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ require 'awestruct/version' | |||
| spec = Gem::Specification.new do |s| | |||
| s.name = 'awestruct' | |||
| s.version = Awestruct::VERSION | |||
| s.date = '2013-12-03' | |||
| s.date = '2013-12-04' | |||
There was a problem hiding this comment.
Not sure if we need this change, I think it's auto generated. Really not sure why this would have changed.
|
Everything else looks good. |
|
Yeah I'm not quite sure how that changed :(, should I revert it back and push again? |
|
Yeah, let's get a pull request that's just the bits that actually need to On Mon, Dec 9, 2013 at 2:16 PM, Fernando Mendez notifications@github.comwrote:
Jason Porter |
LightGuard
added a commit
that referenced
this pull request
Dec 10, 2013
Fix deprecated messages from rspec mock and any_number_of_time. Excellent! Thank you very much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the
mockand theany_number_of_timefunctions within the specs were replace by a non-deprecated alternative.