Improve decoding of SSID name #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #7, the SSID decoding failed in a number of situations where the SSID name used non-ascii or other control sequences. This change improves the decoding to match the encoding as done by hostap: https://w1.fi/cgit/hostap/tree/src/utils/common.c?id=b20991da6936a1baae9f2239ee127610a6f5335d#n477
awilliams
added a commit
to awilliams/packages
that referenced
this pull request
Sep 14, 2022
This version better decodes SSID names which contain emoji, control characters, and other non-ascii characters. awilliams/wifi-presence#8 Signed-off-by: Adam Williams <pwnfactory@gmail.com>
awilliams
added a commit
to awilliams/packages
that referenced
this pull request
Sep 14, 2022
This version better decodes SSID names which contain emoji, control characters, and other non-ascii characters. awilliams/wifi-presence#8 Signed-off-by: Adam Williams <pwnfactory@gmail.com>
neheb
pushed a commit
to openwrt/packages
that referenced
this pull request
Sep 22, 2022
This version better decodes SSID names which contain emoji, control characters, and other non-ascii characters. awilliams/wifi-presence#8 Signed-off-by: Adam Williams <pwnfactory@gmail.com>
1582130940
pushed a commit
to 1582130940/OpenWrt-Lean-Packages
that referenced
this pull request
Nov 10, 2022
This version better decodes SSID names which contain emoji, control characters, and other non-ascii characters. awilliams/wifi-presence#8 Signed-off-by: Adam Williams <pwnfactory@gmail.com>
1582130940
pushed a commit
to 1582130940/OpenWrt-Lean-Packages
that referenced
this pull request
Nov 10, 2022
This version better decodes SSID names which contain emoji, control characters, and other non-ascii characters. awilliams/wifi-presence#8 Signed-off-by: Adam Williams <pwnfactory@gmail.com>
1582130940
pushed a commit
to 1582130940/OpenWrt-Lean-Packages
that referenced
this pull request
Nov 10, 2022
This version better decodes SSID names which contain emoji, control characters, and other non-ascii characters. awilliams/wifi-presence#8 Signed-off-by: Adam Williams <pwnfactory@gmail.com>
stokito
pushed a commit
to stokito/packages
that referenced
this pull request
Dec 6, 2022
This version better decodes SSID names which contain emoji, control characters, and other non-ascii characters. awilliams/wifi-presence#8 Signed-off-by: Adam Williams <pwnfactory@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #7, the SSID decoding failed in a number of situations where the SSID name used non-ascii or other control sequences. This change improves the decoding to match the encoding as done by
hostap: https://w1.fi/cgit/hostap/tree/src/utils/common.c?id=b20991da6936a1baae9f2239ee127610a6f5335d#n477