Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AIX support #11

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add AIX support #11

merged 1 commit into from
Nov 16, 2023

Conversation

jtroy
Copy link
Contributor

@jtroy jtroy commented Oct 4, 2023

This PR adds AIX support. Note, on AIX:

Cirrus CI doesn't support AIX, but I have confirmed that the tests pass when given PV_ROOT privileges. Also note that -race isn't supported on aix/ppc64.

bash-4.4$ go test -count=1 -v ./...
=== RUN   TestCycle
--- PASS: TestCycle (0.00s)
=== RUN   TestProtect
--- PASS: TestProtect (0.00s)
=== RUN   TestProtFlags
--- PASS: TestProtFlags (0.00s)
=== RUN   TestGetStartPtr
--- PASS: TestGetStartPtr (0.00s)
PASS
ok      github.com/awnumar/memcall      0.017s

Also, without PV_ROOT, for the sake of completeness:

bash-4.4$ go test -count=1 -v ./...
=== RUN   TestCycle
    memcall_test.go:25: <memcall> could not acquire lock on 0xa00000046c55000, do you have PV_ROOT? [Err: not owner]
    memcall_test.go:36: <memcall> could not free lock on 0xa00000046c55000, do you have PV_ROOT? [Err: not owner]
--- FAIL: TestCycle (0.00s)
=== RUN   TestProtect
--- PASS: TestProtect (0.00s)
=== RUN   TestProtFlags
--- PASS: TestProtFlags (0.00s)
=== RUN   TestGetStartPtr
--- PASS: TestGetStartPtr (0.00s)
FAIL
FAIL    github.com/awnumar/memcall      0.018s
FAIL

This is mostly copy-pasted from the Darwin implementation. I didn't want to muddy the waters, but I'm happy to do some refactoring if you like. Thanks, and let me know if there's anything else you need.

-John

@awnumar
Copy link
Owner

awnumar commented Nov 16, 2023

Thanks for the PR ❤️

@awnumar awnumar merged commit 7d67f13 into awnumar:master Nov 16, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants