Add PlaintextSize method to Enclaves #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why it fails on Windows... |
|
Good idea, thanks for the pull request. I don't know why the test is failing on Windows either, there is no modules.txt file because dependencies aren't being vendored... |
|
I wasn't sure what to name the new method, I like |
awnumar
added a commit
that referenced
this pull request
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the ciphertext of Enclaves is not a secret, and given that we know the size overhead of storing plaintext in an Enclave, it would be useful and more efficient to have a function that returns the size of the plaintext, without needing to create a LockedBuffer and get the size of it's protected bytes.