Add isPromise #61
Merged
Add isPromise #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awolden
reviewed
Nov 4, 2016
| @@ -257,6 +257,8 @@ isOpen|N/A|boolean|Returns `true` if circuit is open | |||
| - **healthCheckInterval**: time in `ms` interval between each execution of health check function | |||
| - **healthCheck**: function to call for the health check (can be defined also with calling `healthCheck` function) | |||
| - **fallback**: function to call for fallback (can be defined also with calling `fallback` function) | |||
| - **isPromise**: `boolean` to opt out of check for callback in function | |||
There was a problem hiding this comment.
We should add something in here telling the user that the flag will also be applied to thehealthCheck and fallback. I don't think that will be obvious to an end-user.
|
Lgtm. Might suggest we export a |
|
@awolden ping 😄 |
|
@sveisvei as these idiosyncrasies show up in the library it lends itself to rethinking how the API for brakes is designed, and it is good food for though regarding a possible version 3. For now, I think this change is satisfactory as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #39
/cc @sveisvei