Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing other values, e.g. executionRoleArn #19

Closed
skinofstars opened this issue Apr 7, 2020 · 2 comments
Closed

Changing other values, e.g. executionRoleArn #19

skinofstars opened this issue Apr 7, 2020 · 2 comments

Comments

@skinofstars
Copy link

I wonder if there's a way for allowing this to update other values in the definition, e.g. executionRoleArn

The executionRoleArn includes the account ID, which may not be ideal to include in a public repo.

@clareliguori
Copy link
Member

I'm open to contributions! :)

FWIW both the executionRoleArn and taskRoleArn can actually be just the role name. ECS will fill in the account ID server-side when the task definition is registered.

  "executionRoleArn": "my-execution-role-name",
  "taskRoleArn": "my-task-role-name",

@skinofstars
Copy link
Author

What open source maintainer isn't looking for patches? Alas, you've solved my problem perfectly. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants