Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are multiple containers in one task. Can I specify multiple container names for container-name? #4

Closed
sin-to-jin opened this issue Dec 5, 2019 · 2 comments

Comments

@sin-to-jin
Copy link

Current

  - name: Fill in the new image ID in the Amazon ECS task definition
       id: task-def
       uses: aws-actions/amazon-ecs-render-task-definition@v1
       with:
         task-definition: task-definition.json
         container-name: sample-app
         image: ${{ steps.build-image.outputs.image }}

Asking

  - name: Fill in the new image ID in the Amazon ECS task definition
       id: task-def
       uses: aws-actions/amazon-ecs-render-task-definition@v1
       with:
         task-definition: task-definition.json
         container-name: 
           - sample-app1
           - sample-app2
         image: ${{ steps.build-image.outputs.image }}
@clareliguori
Copy link
Member

You can chain this action to fill in multiple images:

    - name: Render Amazon ECS task definition
      id: render-web-container-1
      uses: aws-actions/amazon-ecs-render-task-definition@v1
      with:
        task-definition: task-definition.json
        container-name: web1
        image: amazon/amazon-ecs-sample:latest

    - name: Render 2
      uses: aws-actions/amazon-ecs-render-task-definition@v1
      with:
        task-definition: ${{ steps.render-web-container-1.outputs.task-definition }}
        container-name: web2
        image: amazon/amazon-ecs-sample:latest

@JayDarjiAubergine
Copy link

Does this this chaining going to create multiple task definitions objects for every new render in chain? @clareliguori @sin-to-jin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants