TemplateURL with Nested Stacks is not updated

[dkhmelenko]

I'm getting the following error TemplateURL must be an Amazon S3 URL. whenever I'm using a nested stack.

My root stack looks like this

AWSTemplateFormatVersion: '2010-09-09'
Description: 'Root stack template'
Resources:
  ObjectStorageStack:
    Type: AWS::CloudFormation::Stack
    Properties: 
      TemplateURL: 'object_storage_template.yml'

And nested stack is in file object_storage_template.yml

Resources:
    ObjectBucket:
      Type: AWS::S3::Bucket

I would expect that this deploy action performs packaging and therefore the TemplateURL gets updated.

Is this behavior supported by this action?

[katallaxie]

The behavior is not supported by the action. How would like to have this behavior implemented? We would have to govern a bucket and perhaps resolved some other things.

[dkhmelenko]

Ideally, it would be cool to execute aws cloudformation package, but seems there is no such option in SDKs so far. That being set we need to upload nested stack beforehand to S3.

That would be fine for now, but we need to pass S3 bucket name to the config somehow. I was expected to specify the configuration in key-value pair as s3-bucket=<my_bucket_name>, however, it doesn't work.

[katallaxie]

Let me point out, that

aws-cloudformation-github-deploy/action.yml

Line 10 in 79dba85

template:

template can be an S3 url. So you could upload everything before and then execute with the action. However, there is no officially supported action for the upload.

[dkhmelenko]

I would prefer to have a template in a repository and then get it to upload through this action to AWS. As far as I know, CloudFormation uploads the template first to S3. Is it possible to know what is the S3 bucket used?

[katallaxie]

In order to support the behavior we will have to replicate the upload behavior of the AWS CLI.

[dkhmelenko]

Correct. I realized that. So far my solution works in a way that I have to run aws cloudformation package command. Would be nice to have it as part of this action.

If this is not planned, feel free to close this issue.

[katallaxie]

closing this in favour of #33