Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub OIDC is now using library of trusted CAs #763

Closed
wellsiau-aws opened this issue Jul 7, 2023 · 2 comments · Fixed by #764
Closed

GitHub OIDC is now using library of trusted CAs #763

wellsiau-aws opened this issue Jul 7, 2023 · 2 comments · Fixed by #764
Labels
documentation This is an issue with documentation

Comments

@wellsiau-aws
Copy link

Describe the issue

I noticed that the GitHub action identity provider in the AWS IAM console now has a banner as follow:

AWS secures communication with this OIDC identity provider (IdP) using our library of trusted CAs rather than using a certificate thumbprint to verify the server certificate of your IdP. 
Your legacy thumbprint(s) will remain in your configuration but will no longer be needed for validation.

This should permanently solve the frequent problems as reported in #357

I suggest that to add short blurb in the sample-iam-oidc-cloudformation-template to account for this changes.

@wellsiau-aws wellsiau-aws added documentation This is an issue with documentation needs-triage This issue still needs to be triaged labels Jul 7, 2023
@peterwoodworth peterwoodworth removed the needs-triage This issue still needs to be triaged label Jul 7, 2023
@peterwoodworth
Copy link
Contributor

We're on it, thanks for noticing this and letting us know!

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is an issue with documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants