feat(aws-datastore): Make the Sync Engine pausable/resumable on connectivity changes #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
div5yesh
previously approved these changes
Feb 28, 2023
mattcreaser
reviewed
Mar 1, 2023
aws-datastore/src/main/java/com/amplifyframework/datastore/syncengine/StorageObserver.java
Show resolved
Hide resolved
aws-datastore/src/main/java/com/amplifyframework/datastore/syncengine/Orchestrator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com>
div5yesh
approved these changes
Mar 2, 2023
mattcreaser
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes: #1757
Closes: #1963
Description of changes:
How did you test these changes?
Created an application with a custom ReachabilityMonitor to have control of the network status events. Tested toggling network connectivity and verified that only the network related pieces of DataStore were being paused/resumed correctly (e.g. The subscriptions/queries/mutations would happen again on connectivity available).
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.