fix(datastore): Load pending mutations one at a time from outbox #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
div5yesh
previously approved these changes
May 2, 2023
mattcreaser
requested changes
May 3, 2023
aws-datastore/src/main/java/com/amplifyframework/datastore/syncengine/MutationQueue.java
Show resolved
Hide resolved
...astore/src/main/java/com/amplifyframework/datastore/syncengine/PersistentMutationOutbox.java
Show resolved
Hide resolved
...astore/src/main/java/com/amplifyframework/datastore/syncengine/PersistentMutationOutbox.java
Show resolved
Hide resolved
...astore/src/main/java/com/amplifyframework/datastore/syncengine/PersistentMutationOutbox.java
Outdated
Show resolved
Hide resolved
...astore/src/main/java/com/amplifyframework/datastore/syncengine/PersistentMutationOutbox.java
Outdated
Show resolved
Hide resolved
mattcreaser
approved these changes
May 4, 2023
gpanshu
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1869
Description of changes: Modifies the PersistentMutationOutbox to load pending mutations one at a time, rather than storing all pending mutations in a queue, to reduce memory usage.
How did you test these changes?
Ran existing tests and tested in a sample app.
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.