Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Use provided Content-Type to create RequestBody #2666

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2647

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner December 29, 2023 18:05
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1bebd89) 41.80% compared to head (ea45171) 41.84%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2666      +/-   ##
==========================================
+ Coverage   41.80%   41.84%   +0.03%     
==========================================
  Files         902      902              
  Lines       28998    29005       +7     
  Branches     4108     4110       +2     
==========================================
+ Hits        12124    12137      +13     
+ Misses      15546    15541       -5     
+ Partials     1328     1327       -1     

ankpshah
ankpshah previously approved these changes Dec 29, 2023
gpanshu
gpanshu previously approved these changes Jan 2, 2024
ankpshah
ankpshah previously approved these changes Jan 3, 2024
@tylerjroach tylerjroach dismissed stale reviews from ankpshah and gpanshu via 349b595 January 10, 2024 15:53
@tylerjroach tylerjroach enabled auto-merge (squash) January 11, 2024 15:21
@tylerjroach tylerjroach merged commit 861468f into main Jan 11, 2024
4 checks passed
@tylerjroach tylerjroach deleted the tjroach/fix-api-content-type branch January 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants