Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-auth-cognito): Adds clientMetadata to AWSCognitoAuthSignUpOptions #1407

Merged
merged 3 commits into from
Jul 12, 2021
Merged

feat(aws-auth-cognito): Adds clientMetadata to AWSCognitoAuthSignUpOptions #1407

merged 3 commits into from
Jul 12, 2021

Conversation

haverchuck
Copy link
Contributor

Description of changes:
Adds clientMetadata to AWSCognitoAuthSignUpOptions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haverchuck haverchuck requested a review from a team July 9, 2021 20:29
rjuliano
rjuliano reviewed Jul 9, 2021
View reviewed changes
aws-auth-cognito/src/test/java/com/amplifyframework/auth/cognito/AuthComponentTest.java Outdated

AWSCognitoAuthSignUpOptions options = AWSCognitoAuthSignUpOptions.builder()
.userAttribute(AuthUserAttributeKey.email(), ATTRIBUTE_VAL)
.validationData(METADATA)
.clientMetadata(METADATA)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a different value for clientMetadata just to be on the safe side?

rjuliano
rjuliano approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@rjuliano rjuliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but other than that LGTM. 🚢

richardmcclellan
richardmcclellan approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@richardmcclellan richardmcclellan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@haverchuck haverchuck mentioned this pull request Jul 9, 2021
Merged
@haverchuck
Copy link
Contributor Author

@rjuliano I responded to your PR feedback, please take a look at your convenience!

@richardmcclellan
Copy link
Contributor

@haverchuck the unit tests failed due to a checkstyle issue:

> Task :aws-auth-cognito:checkstyle
--
461 | [ant:checkstyle] [ERROR] /codebuild/output/src601626422/src/github.com/aws-amplify/amplify-android/aws-auth-cognito/src/test/java/com/amplifyframework/auth/cognito/AuthComponentTest.java:138: Line is longer than 120 characters (found 124). [LineLength]
462 | [ant:checkstyle] [ERROR] /codebuild/output/src601626422/src/github.com/aws-amplify/amplify-android/aws-auth-cognito/src/test/java/com/amplifyframework/auth/cognito/AuthComponentTest.java:139: Line is longer than 120 characters (found 128). [LineLength]

@richardmcclellan richardmcclellan merged commit 5e300cb into aws-amplify:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardmcclellan richardmcclellan richardmcclellan approved these changes

@rjuliano rjuliano rjuliano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haverchuck @richardmcclellan @rjuliano