feat(auth): add options to resetPassword and confirmResetPassword #1426
Conversation
|
Can you please elaborate on what type of testings you have done? We are looking for something more involved than just unit testing. Have you integrated this in sample apps to see if it works? |
|
Hi @frimfram - For context, I am adding this for use in amplify-flutter. I have tested an end to end reset password flow from a flutter app with the changes in aws-amplify/amplify-flutter#743 and confirmed that I can see the metadata in a lambda trigger. If there is something specific you are looking for from a testing perspective, please let me know. |
|
@frimfram - Here are the scenarios that I tested for resetPassword and confirmResetPassword. Each of these scenarios were from a native Android app. For both APIs I first tested v1.21.0 of amplify-android to confirm existing behavior, and then tested with the changes in this PR (with and without options/metadata). Reset Password Scenarios
Confirm Reset Password Scenarios
|
| @@ -653,10 +657,17 @@ public void onError(Exception exception) { | |||
| @Override | |||
| public void resetPassword( | |||
| @NonNull String username, | |||
| @NonNull AuthResetPasswordOptions options, | |||
There was a problem hiding this comment.
It would be great if overriding is used instead of this breaking change.
There was a problem hiding this comment.
resetPassword() on line 698 has the same method signature as the existing method. This will not be breaking.
…at/auth/password-options
Issue #, if available: N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.