fix(datastore): SerializedCustomType de/serialization #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
fix/datastore/serialized-custom-type
branch
3 times, most recently
from
259484c
to
975c2d7
Compare
HuiSF
force-pushed
the
fix/datastore/serialized-custom-type
branch
from
975c2d7
to
4a08705
Compare
6 tasks
mattcreaser
approved these changes
Apr 27, 2023
6 tasks
dnys1
pushed a commit
that referenced
this pull request
Aug 3, 2023
Fixes: aws-amplify/amplify-flutter#3472, aws-amplify/amplify-flutter#3482 The issue of ser/deseralizing custom types was partially fixed by #2350. However, once this was released, customers quickly noticed new issues. The prior fix did not handle arrays of custom types which this PR addresses.
dnys1
pushed a commit
that referenced
this pull request
Aug 3, 2023
Fixes: aws-amplify/amplify-flutter#3472, aws-amplify/amplify-flutter#3482 The issue of ser/deseralizing custom types was partially fixed by #2350. However, once this was released, customers quickly noticed new issues. The prior fix did not handle arrays of custom types which this PR addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-amplify/amplify-flutter#2710
Description of changes:
The use cases of this changes are specific to amplify-flutter DataStore context, and are isolated from native amplify-android DataStore.
SerializedCustomTypeAdapterused by Gson to allow include custom type schema and serialized data (exmaple) (this serialization process is used for saving pending mutation intoPersistentRecordtable of the local SQLite DB, when saving a model that has nested custom types but the device is offline)SerializedModelAdapterused by Gson to allow correctly serialize nested custom typesgetFlatSerializedDatatoSerializedCustomTypeto return pure data without serialized schema info (example)SQLiteModelFieldTypeConverterto ensure correct custom type json value to be written into local database without serialized schema infoHow did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.