Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Add AuthMode to ModelSubscription #2829

Merged
merged 1 commit into from
May 28, 2024
Merged

feat(api): Add AuthMode to ModelSubscription #2829

merged 1 commit into from
May 28, 2024

Conversation

mattcreaser
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Added an authMode parameter to the various ModelSubscription APIs

How did you test these changes?

  • Unit test
  • Test app

Documentation update required?

  • No
  • Yes Documentation TODO

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners May 24, 2024 15:39
@tylerjroach tylerjroach merged commit 3e25c14 into feat/auth-mode May 28, 2024
1 check passed
@tylerjroach tylerjroach deleted the mattcreaser/api-auth-mode-subscription branch May 28, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjroach tylerjroach tylerjroach approved these changes

@lawmicha lawmicha lawmicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattcreaser @tylerjroach @lawmicha