chore: revert previous change but keep added test coverage

aws-amplify · May 20, 2024 · 438ccf0 · 438ccf0
1 parent 37a4fdf
commit 438ccf0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/packages/auth-construct/src/construct.test.ts b/packages/auth-construct/src/construct.test.ts
@@ -793,8 +793,7 @@ void describe('Auth construct', () => {
               oauthRedirectSignIn: 'http://callback.com',
               oauthRedirectSignOut: 'http://logout.com',
               oauthResponseType: 'code',
-              // see: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpoolclient.html#cfn-cognito-userpoolclient-supportedidentityproviders
-              socialProviders: `["${googleProvider.providerName}","${facebookProvider.providerName}","${amazonProvider.providerName}","${appleProvider.providerName}","${provider1}","${provider2}","${unnamedProvider}"]`,
+              socialProviders: `["GOOGLE","FACEBOOK","LOGIN_WITH_AMAZON","SIGN_IN_WITH_APPLE","${provider1}","${provider2}","${unnamedProvider}"]`,
               allowUnauthenticatedIdentities: 'true',
               mfaConfiguration: 'OFF',
               mfaTypes: '[]',

diff --git a/packages/auth-construct/src/construct.ts b/packages/auth-construct/src/construct.ts
@@ -969,20 +969,10 @@ export class AmplifyAuth
     });
     output.mfaTypes = JSON.stringify(mfaTypes);
 
-    // extract providers from CfnIdentityPool.supportedLoginProviders
-    // see: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpoolclient.html#cfn-cognito-userpoolclient-supportedidentityproviders
-    const cfnUserPoolProviders =
-      this.resources.cfnResources.cfnUserPoolClient.supportedIdentityProviders;
-    if (cfnUserPoolProviders) {
-      const providersToOutput = [];
-      for (const provider of cfnUserPoolProviders) {
-        if (provider !== 'COGNITO') {
-          providersToOutput.push(provider);
-        }
-      }
-      if (providersToOutput.length > 0) {
-        output.socialProviders = JSON.stringify(providersToOutput);
-      }
+    if (this.providerSetupResult.providersList.length > 0) {
+      output.socialProviders = JSON.stringify(
+        this.providerSetupResult.providersList
+      );
     }
 
     //TODO: extract callback URLs from cfn and remove this block below