Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for function logs streaming to sandbox #1492
base: main
Are you sure you want to change the base?
feat: add support for function logs streaming to sandbox #1492
Changes from all commits
74ccb5f
4d30c77
9141649
11bc7b6
3dacebd
841a4c3
376de18
6fd0a63
e8bbf91
e15bcbf
8fbeb3b
b589fdb
c4d423e
79223a6
ffb9791
b5bcb12
717698d
6187471
18fc156
775b543
a6499ae
4b4b6ec
d141d30
1639594
b4b1506
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't a regex for "functions starting with auth" be
^auth.*
? Also, why are we supporting regex and array input? You can make a regex to support multiple disjoint strings with(foo|bar|baz)
IMO if we are going to support regex, it should just be a single arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 yes the important piece of regex is the wildcard match (e.g.
auth*
picks up all functions named withauth
likeauth-post-confirmation
andauth-pre-signup
) but it is much easier to specify multiple patterns than it is to craft complex regex when writing the commandI think regex can be a bit of a hurdle though compared to a glob pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to support glob patterns or regex then? The current impl is using regex which would require
--logs-filter auth.* logs-filter resolver.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glob patterns don't make sense for non pathlike strings. Globs are typically (or only?) used for pathname expansions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah fair enough. Just want to make sure we're aligned that customers will have to specify
auth.*
, notauth*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are use cases for glob patterns outside filenames
https://www.sqlitetutorial.net/sqlite-glob/
https://duckdb.org/docs/sql/functions/pattern_matching.html#glob
like minimatch without the globstar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimatch is basically a glob implementation, still only relevant for pathlike string matching, not for any arbitrary matches.
In the SQL world, the
glob
is basically implemented as a regex, e.g. there is no such thing as**
.