Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly generate Gen1 social provider config form Gen2 #1514

Merged
merged 1 commit into from
May 14, 2024

Conversation

Amplifiyer
Copy link
Contributor

Follow up from #1507

Changes

Gen1/Legacy config contains social providers as APPLE and AMAZON while Gen2 is LOGIN_WITH_AMAZON and SIGN_IN_WITH_APPLE.

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Amplifiyer Amplifiyer requested a review from a team as a code owner May 14, 2024 13:44
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: b6b91b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/client-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amplifiyer Amplifiyer merged commit f7b8089 into main May 14, 2024
35 checks passed
@Amplifiyer Amplifiyer deleted the config_fix_apple_signin branch May 14, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants